tests: add insertBlockAndWaitForSelector utility
#56642
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flootr
added
[Tool] E2E Test Utils
flootr
added
[Type] Automated Testing
|
Flaky tests detected in 0c1f48e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7033437691
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a
insertBlockAndWaitForSelectorutility to the e2e test utils for playwright package which inserts a block and then waits for a given selector to be visible.Why?
The idea came up when I started working on fixing e2e tests in #55585 which attempts to lazy load edit functions of blocks. After using
insertBlockwe have to wait for a certain selector to be visible, otherwise some of the tests fail which attempt to e.g. type something into a block which isn't there yet.In 50cd450 you can see this might result in a lot of repetitive code which this util tries to abstract away. It's probably not suitable for all block insertions done in those tests but should cover a fair bit.
How?
The
@wordpress/e2e-test-utils-playwrightexports a bunch of methods and we're addinginsertBlockAndWaitForSelectorto it.Testing Instructions
Testing Instructions for Keyboard
none
Screenshots or screencast
none